Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate json_t from parsing the json string #143

Merged
merged 2 commits into from
Nov 21, 2024

Conversation

xw19
Copy link

@xw19 xw19 commented Nov 20, 2024

Generating the initial json_t instead of yajl_val and remove temporary function

Part of #138

@saschagrunert
Copy link
Member

@giuseppe PTAL, code LGTM

Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@giuseppe giuseppe merged commit d4b35ce into containers:switch-to-jansson Nov 21, 2024
6 checks passed
@giuseppe
Copy link
Member

@saschagrunert please merge to switch-to-jansson as soon as you are happy with it :-)

I think it is more important to move fast with the prototyping, we can deal with minor details later

@giuseppe
Copy link
Member

@saschagrunert added you as a maintainer of the project

@saschagrunert
Copy link
Member

@giuseppe thank you!

@xw19
Copy link
Author

xw19 commented Nov 21, 2024

@saschagrunert @giuseppe Parsing of json has been converted to jansson only genration part still uses yajl by next week we should be using only jansson.

@saschagrunert
Copy link
Member

Refers to #138

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants